Skip to content

fix(vite): handle runtime paths in inlined styles#27327

Merged
danielroe merged 3 commits intomainfrom
fix/inline-styles
May 23, 2024
Merged

fix(vite): handle runtime paths in inlined styles#27327
danielroe merged 3 commits intomainfrom
fix/inline-styles

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #26895

📚 Description

A regression in #26163 was the dropping of support for runtime public assets directories. This PR adds support back by manipulating the CSS-in-JS chunks emitted by the server.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title test: add failing test for urls in rendered inline styles fix(vite): handle runtime paths in inlined styles May 23, 2024
Comment thread test/basic.test.ts
return
}

expect(file).toMatch(new RegExp(`^${base.replace(/\//g, '\\/')}`))

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This does not escape backslash characters in the input.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app.cdnURL not applied to URLs in global CSS files

2 participants