perf(nuxt): abort vue render when plugins throw error#27304
Merged
Conversation
|
|
|
here's a similar issue but for middlewares, will this PR fix it or its just for plugins? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #25518
📚 Description
It turns out that when we were throwing an error in plugins (or anywhere before the vue app started rendering) we were then rendering the error page twice - once on the initial request (which is discarded) and then again when we are intentionally rendering an error page.
A possible performance improvement might be using that initial render instead of running plugins twice. But for now, I think it's safer to keep the separated error render for consistency.