feat(nuxt): auto-register layers in layers/ directory#27221
Merged
Conversation
|
|
Member
|
Seems good to me at first sight. I would maybe named it |
Member
|
Member
Author
|
It should be fine as we are not exposing this or even allowing users to provide their own config, so it's purely internal within this file. |
Contributor
|
Will each layer have it's own tsconfig? |
Member
Damn, then it's good for me! |
atinux
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
follow up on #26444
📚 Description
This auto-registers layers located in a top-level
~~/layersdirectory. To avoid collisions with user layer configuration, it adds a new internal_extendskey to nuxt options, and then instructsc12to read from that. This seems like a more straightforward/correct way than attempting to add an auto-registration feature toc12itself.Would love your thoughts particularly @pi0 with regard to c12 approach.