Skip to content

feat(nuxt): add onUpdated and onUnmounted into treeshakeable composables#27044

Merged
danielroe merged 2 commits intonuxt:mainfrom
Mini-ghost:feature/add-treeshakeable-composables
May 3, 2024
Merged

feat(nuxt): add onUpdated and onUnmounted into treeshakeable composables#27044
danielroe merged 2 commits intonuxt:mainfrom
Mini-ghost:feature/add-treeshakeable-composables

Conversation

@Mini-ghost
Copy link
Copy Markdown
Member

@Mini-ghost Mini-ghost commented May 3, 2024

🔗 Linked issue

N/A

📚 Description

Currently, optimization.treeShake.composables missing some composable, such as onUpdated and onUnmounted.

server: {
$resolve: async (val, get) => defu(val || {},
await get('dev')
? {}
: {
'vue': ['onBeforeMount', 'onMounted', 'onBeforeUpdate', 'onRenderTracked', 'onRenderTriggered', 'onActivated', 'onDeactivated', 'onBeforeUnmount'],
'#app': ['definePayloadReviver', 'definePageMeta'],
},
),
},

This PR adds these two composables and adjusts the sorting to match the order on the vue document.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants