Skip to content

fix(nuxt): skip scanning component directories when enabled is set to false#26906

Merged
danielroe merged 4 commits intonuxt:mainfrom
Gehbt:patch-1
Apr 23, 2024
Merged

fix(nuxt): skip scanning component directories when enabled is set to false#26906
danielroe merged 4 commits intonuxt:mainfrom
Gehbt:patch-1

Conversation

@Gehbt
Copy link
Copy Markdown
Contributor

@Gehbt Gehbt commented Apr 23, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

fix ineffective ScanDir.enable option on gen components.d.ts

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz Bot commented Apr 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Gehbt Gehbt changed the title fix(nuxt): fix ineffective ScanDir.enable option on gen components fix(nuxt): fix ineffective option of generate components.d.ts Apr 23, 2024
danielroe
danielroe reviewed Apr 23, 2024
View reviewed changes
Comment thread packages/nuxt/src/components/scan.ts Outdated
danielroe
danielroe reviewed Apr 23, 2024
View reviewed changes
Comment thread packages/nuxt/src/components/scan.ts Outdated
@danielroe danielroe changed the title fix(nuxt): fix ineffective option of generate components.d.ts fix(nuxt): skip scanning component directories when enabled is set to false Apr 23, 2024
@danielroe danielroe merged commit 9f9e3e6 into nuxt:main Apr 23, 2024
@github-actions github-actions Bot mentioned this pull request Apr 23, 2024
Merged
4 tasks
@Gehbt Gehbt deleted the patch-1 branch April 23, 2024 14:14
@BalaKadiyala BalaKadiyala mentioned this pull request Jul 10, 2024
Open
@BalaKadiyala BalaKadiyala mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

3.x bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gehbt @danielroe