Skip to content

perf(nuxt): unsubscribe from asyncData watch when component is unmounted#26821

Merged
danielroe merged 2 commits intonuxt:mainfrom
daniluk4000:fix/26820
Apr 17, 2024
Merged

perf(nuxt): unsubscribe from asyncData watch when component is unmounted#26821
danielroe merged 2 commits intonuxt:mainfrom
daniluk4000:fix/26820

Conversation

@daniluk4000
Copy link
Copy Markdown
Contributor

🔗 Linked issue

Resolves #26820

📚 Description

Fixes performance degradation inproduced in #26554

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Comment thread packages/nuxt/src/app/composables/asyncData.ts Outdated
@danielroe danielroe merged commit 468ebbd into nuxt:main Apr 17, 2024
@github-actions github-actions Bot mentioned this pull request Apr 17, 2024
4 tasks
@daniluk4000 daniluk4000 deleted the fix/26820 branch April 17, 2024 13:00
@daniluk4000
Copy link
Copy Markdown
Contributor Author

Can confirm original issue is fixed in latest nightly build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useAsyncData is not cleared when using defineNuxtComponent

2 participants