fix: navigation dir confs handle missing query params#2772
Merged
fix: navigation dir confs handle missing query params#2772
Conversation
farnabaz
reviewed
Sep 12, 2024
Comment on lines
35
to
37
|
|
||
| const dirConfigs = await serverQueryContent(event) | ||
| const dirConfigs = await serverQueryContent(event, query) | ||
| .where({ _path: /\/_dir$/i, _partial: true }) | ||
| .find() |
Member
There was a problem hiding this comment.
Using user's query in configs search might result in loosing some configs. Imagine user filter documents based on their path or title.
What if we use first retrieved content to get the locale and use it in configs query?
const dirConfigs = await serverQueryContent(event, contents.length ? { _locale: contents[0]._length } : {})
.where({ _path: /\/_dir$/i, _partial: true })
.find()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #2771
❓ Type of change
📚 Description
📝 Checklist