Skip to content

fix(types): add const type parameter for .only() and .without()#2573

Merged
farnabaz merged 1 commit intonuxt:mainfrom
thunfisch987:fix/query-types
Feb 29, 2024
Merged

fix(types): add const type parameter for .only() and .without()#2573
farnabaz merged 1 commit intonuxt:mainfrom
thunfisch987:fix/query-types

Conversation

@thunfisch987
Copy link
Copy Markdown
Contributor

🔗 Linked issue

#2546

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR enables having better types when using the .only() function and uses the const type parameter feature that was introduced in Typescript 5.0

I noticed that my previous PR only included the .only() in runtime/types/query.ts when it should have also included the ones in runtime/types/index.ts

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Copy Markdown
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants