Expand SupportOSPlatform to mean minimum supported version#4569
Expand SupportOSPlatform to mean minimum supported version#4569manfred-brands merged 2 commits intonunit:masterfrom
Conversation
Windows7 => WIndows7, Windows8, Windows10, Windows11 Windows10 => Windows10, Windows11 Added windows only test assembly with MS generated SupportOSPlatform attribute
a8b133b to
5e557a6
Compare
stevenaw
left a comment
There was a problem hiding this comment.
Thanks for the prompt PR @manfred-brands !
No concerns from me, LGTM.
|
Could you please publish this somewhere (MyGet, ...) to easily try it? |
The nuget package is available from the build action |
|
That doesn't quite cut it - icsharpcode/ILSpy#3132 in addition to local failures, we are also failing on GH actions. I don't want to check in a binary just for testing. |
|
I have pushed the latest up to MyGet at https://www.myget.org/feed/nunit/package/nuget/NUnit/4.1.0-adev.1 |
|
Let's find out then how dotnet test fares on GH with the new package icsharpcode/ILSpy@d3de474 |
|
No, it doesn't: https://github.com/icsharpcode/ILSpy/actions/runs/7030026378/job/19128743036 (note locally in VS it works a-ok). Is dotnet test behaving differently than VS in this case then? |
|
It should not. Does it run on command line locally ? |
|
Very, very strange. Locally it works in all those variations: all report Passed! - Failed: 0, Passed: 118, Skipped: 0, Total: 118, Duration: 264 ms - ilspy.tests.dll (net8.0) |
|
Test cases come from a submodule (git submodule update --init --recursive), and yes, we know that Antivirus doesn't like some of the code. ILSpy.Tests is the one with the least dependencies on "strange" use case that were submitted to us. Edit: if there's anything you think might help in making dotnet test more verbose / actually work, please let me know. Editing the workflow yml is not a problem. |
|
You can add "-- NUnit.Verbosity=5" That give you a little bit more information. Are you using any .runsettings file? Also, you can add "NUnit.DumpXmlTestDiscovery=true" and "NUnit.DumpXmlTestResults=true". Add them either on the command line after the Verbosity option, or add all of them to a .runsettings file, Edit: Trying this locally, I can't see any dump folder below the bin/net8-windows folder. And that is weird. |
|
No, no .runsettings. Locally adding -- NUnit.Verbosity=5 doesn't really change much in the output at all.
|
|
I have added --diag to icsharpcode/ILSpy@9982e1c btw, should we move the discussion to a new issue maybe? |
Yes, please do. Did you also add the NUnit.DumpXmlTestResults=true? And, did you get anything in the Dump folder ? |


Fixes #4564
Windows7 => WIndows7, Windows8, Windows10, Windows11
Windows10 => Windows10, Windows11
Added windows only test assembly with MS generated SupportOSPlatform attribute