BUG: Fix f2py directives and --lower casing#28175
Merged
charris merged 2 commits intonumpy:maintenance/2.2.xfrom Jan 18, 2025
Merged
BUG: Fix f2py directives and --lower casing#28175charris merged 2 commits intonumpy:maintenance/2.2.xfrom
charris merged 2 commits intonumpy:maintenance/2.2.xfrom
Conversation
Co-authored-by: germasch <germasch@users.noreply.github.com>
Member
Author
|
Hmm, looks like MacOS with accelerate has hung again on Python 3.13t. @ngoldbaum Do you know of anything that might have fixed this in main? |
Member
|
Maybe try backporting #27899 to at least get some timeouts and diagnostics. The hang might also have been caused by the |
Member
Author
That does sound likely. I'll wait until 2.2.2 is out and then backport selected bits of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28056
Closes #28014 which snuck in over in #27728. Essentially, only the added
f2pydirectives which take C-exprs noted here need to be skipped for the lowering logic (since C is case sensitive).