BUG: move reduction initialization to ufunc initialization#28131
Merged
charris merged 1 commit intonumpy:maintenance/2.2.xfrom Jan 9, 2025
Merged
BUG: move reduction initialization to ufunc initialization#28131charris merged 1 commit intonumpy:maintenance/2.2.xfrom
charris merged 1 commit intonumpy:maintenance/2.2.xfrom
Conversation
* BUG: move reduction initialization to ufunc initialization * MAINT: refactor to call get_initial_from_ufunc during init * TST: add test for multithreaded reductions * MAINT: fix linter * Apply suggestions from code review Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net> * MAINT: simplify further --------- Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28123.
Fixes #28041.
Because the reduction initialization happens during ufunc initialization, this means that ufunc initialization now depends on the allocator context variables being initialized, so I moved those initialization steps up before ufunc initialization in the main
_multiarray_umathmodule initialization function.BUG: move reduction initialization to ufunc initialization
MAINT: refactor to call get_initial_from_ufunc during init
TST: add test for multithreaded reductions
MAINT: fix linter
Apply suggestions from code review
MAINT: simplify further