fix: mirror the legacy global dispatcher for built-in fetch#4962
Merged
fix: mirror the legacy global dispatcher for built-in fetch#4962
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4962 +/- ##
==========================================
+ Coverage 92.92% 92.95% +0.02%
==========================================
Files 111 111
Lines 35831 35827 -4
==========================================
+ Hits 33297 33303 +6
+ Misses 2534 2524 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ronag
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setGlobalDispatcher()toSymbol.for('undici.globalDispatcher.1')on all supported Node.js versions, not only Node.js 22Symbol.for('undici.globalDispatcher.2')fetchactually uses the configured dispatcherWhy
setGlobalDispatcher()in Undici v8 still needs to affect Node.js built-infetchthrough the legacy.1global dispatcher.The current implementation only mirrors
.1on Node.js 22, which breaks the expected behavior on Node.js 24 and 25. That makes repros likesetGlobalDispatcher(new EnvHttpProxyAgent())stop affecting globalfetch, even though manually settingSymbol.for('undici.globalDispatcher.1')still works there.Fixes #4960.
Tests
npx borp -p "test/node-test/global-dispatcher-version.js"/home/matteo/.nvm/versions/node/v22.21.1/bin/npx borp -p "test/node-test/global-dispatcher-version.js"/home/matteo/.nvm/versions/node/v25.2.1/bin/npx borp -p "test/node-test/global-dispatcher-version.js"npx eslint lib/global.js test/node-test/global-dispatcher-version.js