Improve Mark display on compact mode#332
Closed
ooflorent wants to merge 1 commit intonodeca:masterfrom
ooflorent:compact_mark
Closed
Improve Mark display on compact mode#332ooflorent wants to merge 1 commit intonodeca:masterfrom ooflorent:compact_mark
ooflorent wants to merge 1 commit intonodeca:masterfrom
ooflorent:compact_mark
Conversation
Member
Could you explain reasons for this PR? |
Author
The reason behind this change is cosmetic. I have built a tool to format YAML files and errors are handled this way: try {
data = yaml.load(contents)
} catch (e) {
const line = e.mark.line + 1
const column = e.mark.column + 1
console.error(`${e.name}: ${e.reason} (${line}:${column})\n`)
console.error(codeFrame(contents, line, column))
process.exit(1)
}The goal is to be able to switch to compact mode to prevent the code frame from being displayed but keeping the mark concise:
Modifying |
Member
|
Let's keep this open, to revisit on major version bump. |
Member
|
Fixed in a58d8bc (together with stylus-like exception formatting). |
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Before:
After: