Merged
Conversation
* Prevent HTTP request/response smuggling via chunk encoding Motivation: Transfer-Encoding: chunked has some strict rules around parsing CR LF delimiters. If we are too lenient, it can cause request/response smuggling issues when combined with proxies that are lenient in different ways. See https://w4ke.info/2025/06/18/funky-chunks.html for the details. Modification: - Make sure that we reject chunks with chunk-extensions that contain lone Line Feed octets without their preceding Carriage Return octet. - Make sure that we issue HttpContent objects with decoding failures, if we decode a chunk and it isn't immediately followed by a CR LF octet pair. Result: Smuggling requests/responses is no longer possible. Fixes #15522 * Enforce CR LF line separators for HTTP messages by default But also make it configurable through `HttpDecoderConfig`, and add a system property opt-out to change the default back. * Remove property for the name of the strict line parsing property * Remove HeaderParser.parse overload that only takes a buffer argument
10 tasks
takeseem
added a commit
to takeseem/vertx-web
that referenced
this pull request
Sep 14, 2025
Adapt to Netty 4.2.5 strict rules for CRLF delimiters: netty/netty#15611
takeseem
added a commit
to takeseem/vertx-web
that referenced
this pull request
Sep 14, 2025
Adapt to Netty 4.2.5 strict rules for CRLF delimiters: netty/netty#15611
|
Can you confirm it is CVE-2025-58056 and what are the commit fixing for 4.1 ? |
2 tasks
Member
|
@bastien-roucaries it is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Transfer-Encoding: chunked has some strict rules around parsing CR LF delimiters. If we are too lenient, it can cause request/response smuggling issues when combined with proxies that are lenient in different ways. See https://w4ke.info/2025/06/18/funky-chunks.html for the details.
Modification:
Result:
Smuggling requests/responses is no longer possible.
Fixes #15522
But also make it configurable through
HttpDecoderConfig, and add a system property opt-out to change the default back.Remove property for the name of the strict line parsing property
Remove HeaderParser.parse overload that only takes a buffer argument