[refactor] add error message to all new Error() calls#15609
Merged
normanmaurer merged 1 commit intonetty:4.2from Sep 4, 2025
Merged
[refactor] add error message to all new Error() calls#15609normanmaurer merged 1 commit intonetty:4.2from
new Error() calls#15609normanmaurer merged 1 commit intonetty:4.2from
Conversation
chrisvest
reviewed
Sep 2, 2025
eeecf34 to
5ff746f
Compare
Member
|
The two timed-out builds spent multiple hours running the Can you try rebasing, and running those tests locally to see if there's anything weird going on? |
It's treated a bad practices to create exceptions without error message. Even if it seems that the error can never happen, it still can - for example, when someone adds an enum value and forgets to update all switches.
5ff746f to
f1c0822
Compare
Contributor
Author
Sure. I've rebased on 4.2 |
Member
|
I found out why those builds are slow: #15616 It's nothing to do with the changes in this PR. |
chrisvest
approved these changes
Sep 4, 2025
normanmaurer
approved these changes
Sep 4, 2025
Member
|
@asolntsev thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's treated a bad practices to create exceptions without error message.
Motivation:
Even if it seems that the error can never happen, it still can - for example, when someone adds an enum value and forgets to update all switches.
Modification:
Replaced all calls of
new Error()bynew Error("Unexpected something: " + value).