Fix size overflow in AbstractDiskHttpData#15463
Merged
Conversation
Signed-off-by: 秦利斌 <68638598+Allan-QLB@users.noreply.github.com>
yawkat
approved these changes
Jul 11, 2025
chrisvest
approved these changes
Jul 11, 2025
Member
|
Thanks! |
chrisvest
pushed a commit
to chrisvest/netty
that referenced
this pull request
Jul 11, 2025
Motivation: The local variable `written` is int in `AbstractDiskHttpData#setContent(InputStream)`, if the inputstream size is larger than max value of int, it will overflow, as a result the `size` will be wrong Modification: make `written` long Result: `size` does not overflow Signed-off-by: 秦利斌 <68638598+Allan-QLB@users.noreply.github.com>
chrisvest
added a commit
that referenced
this pull request
Jul 11, 2025
Motivation: The local variable `written` is int in `AbstractDiskHttpData#setContent(InputStream)`, if the inputstream size is larger than max value of int, it will overflow, as a result the `size` will be wrong Modification: make `written` long Result: `size` does not overflow Signed-off-by: 秦利斌 <68638598+Allan-QLB@users.noreply.github.com> Co-authored-by: 秦利斌 <68638598+Allan-QLB@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The local variable
writtenis int inAbstractDiskHttpData#setContent(InputStream), if the inputstream size is larger than max value of int, it will overflow, as a result thesizewill be wrongModification:
make
writtenlongResult:
sizedoes not overflow