Add SETTINGS_ENABLE_CONNECT_PROTOCOL to the default HTTP/2 settings#15312
Merged
normanmaurer merged 1 commit intonetty:4.2from Jun 4, 2025
Merged
Conversation
…etty#14995) Motivation: https://datatracker.ietf.org/doc/html/rfc8441#section-9.1 specifies SETTINGS_ENABLE_CONNECT_PROTOCOL as the default setting for enabling the Extended CONNECT. This setting is used for enabling websocket support. Modification: - Add SETTINGS_ENABLE_CONNECT_PROTOCOL to the default HTTP/2 settings - Add junit tests Result: SETTINGS_ENABLE_CONNECT_PROTOCOL is part of the default HTTP/2 settings
normanmaurer
approved these changes
Jun 4, 2025
Member
normanmaurer
left a comment
There was a problem hiding this comment.
Seems like we missed to port this by mistake
Member
Author
|
@normanmaurer thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting PR #14995 (for some reason the commit is missing)
Motivation:
https://datatracker.ietf.org/doc/html/rfc8441#section-9.1 specifies SETTINGS_ENABLE_CONNECT_PROTOCOL as the default setting for enabling the Extended CONNECT. This setting is used for enabling websocket support.
Modification:
Result:
SETTINGS_ENABLE_CONNECT_PROTOCOL is part of the default HTTP/2 settings