Make native image profiles activate on 'native-image' binary#14986
Merged
normanmaurer merged 1 commit intonetty:4.1from Apr 3, 2025
Merged
Make native image profiles activate on 'native-image' binary#14986normanmaurer merged 1 commit intonetty:4.1from
normanmaurer merged 1 commit intonetty:4.1from
Conversation
Motivation: GraalVM no longer include the `$JAVA_HOME/bin/gu` binary. It is also no longer necessary, because graalvm include the `native-image` binary we actually need, by default. Modification: Change the native image maven profile activation to be predicated on the `native-image` binary instead of the `gu` binary. Result: The native image test suites should now run as part of our graal builds.
normanmaurer
approved these changes
Apr 3, 2025
normanmaurer
pushed a commit
that referenced
this pull request
Apr 3, 2025
Motivation: GraalVM no longer include the `$JAVA_HOME/bin/gu` binary. It is also no longer necessary, because graalvm include the `native-image` binary we actually need, by default. Modification: Change the native image maven profile activation to be predicated on the `native-image` binary instead of the `gu` binary. Result: The native image test suites should now run as part of our graal builds.
normanmaurer
added a commit
that referenced
this pull request
Apr 3, 2025
…#14987) Motivation: GraalVM no longer include the `$JAVA_HOME/bin/gu` binary. It is also no longer necessary, because graalvm include the `native-image` binary we actually need, by default. Modification: Change the native image maven profile activation to be predicated on the `native-image` binary instead of the `gu` binary. Result: The native image test suites should now run as part of our graal builds. Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
GraalVM no longer include the
$JAVA_HOME/bin/gubinary. It is also no longer necessary, because graalvm include thenative-imagebinary we actually need, by default.Modification:
Change the native image maven profile activation to be predicated on the
native-imagebinary instead of thegubinary.Result:
The native image test suites should now run as part of our graal builds.