Fix race and leaks introduced in tests by a16f8aaf2ff101567a526916b46…#14588
Merged
normanmaurer merged 1 commit into4.1from Dec 16, 2024
Merged
Fix race and leaks introduced in tests by a16f8aaf2ff101567a526916b46…#14588normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
Motivation: a16f8aa added some more tests for the PcapWriteHandler. Unfortunally these tests had a race and multiple buffer leaks that got undetected while reviewing. Modifications: - Fix race by actually waiting for the data to be received before assert it - Fix leaks and correctly retain / duplicate data Result: No more test failures
normanmaurer
added a commit
that referenced
this pull request
Dec 16, 2024
…d7752aaf44c67 Motivation: a16f8aa added some more tests for the PcapWriteHandler. Unfortunally these tests had a race and multiple buffer leaks that got undetected while reviewing. Modifications: - Fix race by actually waiting for the data to be received before assert it - Fix leaks and correctly retain / duplicate data Result: No more test failures
normanmaurer
added a commit
that referenced
this pull request
Dec 16, 2024
…… (#14588) …d7752aaf44c67 Motivation: a16f8aa added some more tests for the PcapWriteHandler. Unfortunally these tests had a race and multiple buffer leaks that got undetected while reviewing. Modifications: - Fix race by actually waiting for the data to be received before assert it - Fix leaks and correctly retain / duplicate data Result: No more test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d7752aaf44c67
Motivation:
a16f8aa added some more tests for the PcapWriteHandler. Unfortunally these tests had a race and multiple buffer leaks that got undetected while reviewing.
Modifications:
Result:
No more test failures