Don't strip whitespaces from header names and let the validator handl…#14179
Merged
normanmaurer merged 2 commits into4.1from Jul 15, 2024
Merged
Don't strip whitespaces from header names and let the validator handl…#14179normanmaurer merged 2 commits into4.1from
normanmaurer merged 2 commits into4.1from
Conversation
…e these Motivation: We did strip whitespaces from the header names before trying to add these to DefaultHeaderName. We should better not do this as whitespaces as prefix of a header name are not valid in general. Modifications: Don't strip leading whitespaces and so let the validator handle it. Result: Fixes #14177
Member
Author
|
/cc @vietj and @kenballus |
violetagg
approved these changes
Jul 12, 2024
bryce-anderson
approved these changes
Jul 12, 2024
idelpivnitskiy
approved these changes
Jul 12, 2024
normanmaurer
added a commit
that referenced
this pull request
Jul 15, 2024
#14179) …e these Motivation: We did strip whitespaces from the header names before trying to add these to DefaultHeaderName. We should better not do this as whitespaces as prefix of a header name are not valid in general. Modifications: Don't strip leading whitespaces and so let the validator handle it. Result: Fixes #14177
normanmaurer
added a commit
that referenced
this pull request
Jul 15, 2024
#14179) …e these Motivation: We did strip whitespaces from the header names before trying to add these to DefaultHeaderName. We should better not do this as whitespaces as prefix of a header name are not valid in general. Modifications: Don't strip leading whitespaces and so let the validator handle it. Result: Fixes #14177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e these
Motivation:
We did strip whitespaces from the header names before trying to add these to DefaultHeaderName. We should better not do this as whitespaces as prefix of a header name are not valid in general.
Modifications:
Don't strip leading whitespaces and so let the validator handle it.
Result:
Fixes #14177