DnsNameResolver: Fail query if id space is exhausted#13784
Merged
normanmaurer merged 1 commit into4.1from Jan 17, 2024
Merged
Conversation
716be48 to
9e67973
Compare
Motivation: When we try to execute a query we will try to select / generate an id that is used. When we are not able to find one we throw an IllegalStateException. In this case we also need to ensure we fail the original promise as otherwise the user might never be notified of the problem. Modifications: - Move throw code out of the DnsQueryContextManager to make it easier to reason about - Fail query with IllegalStateException Result: Query will be correctly failed in the case of id space exhausting
9e67973 to
60441af
Compare
bryce-anderson
approved these changes
Jan 17, 2024
Contributor
bryce-anderson
left a comment
There was a problem hiding this comment.
Promise leaks are tough.
idelpivnitskiy
approved these changes
Jan 17, 2024
normanmaurer
added a commit
that referenced
this pull request
Jan 18, 2024
Motivation: When we try to execute a query we will try to select / generate an id that is used. When we are not able to find one we throw an IllegalStateException. In this case we also need to ensure we fail the original promise as otherwise the user might never be notified of the problem. Modifications: - Move throw code out of the DnsQueryContextManager to make it easier to reason about - Fail query with IllegalStateException Result: Query will be correctly failed in the case of id space exhausting
franz1981
pushed a commit
to franz1981/netty
that referenced
this pull request
Feb 9, 2024
Motivation: When we try to execute a query we will try to select / generate an id that is used. When we are not able to find one we throw an IllegalStateException. In this case we also need to ensure we fail the original promise as otherwise the user might never be notified of the problem. Modifications: - Move throw code out of the DnsQueryContextManager to make it easier to reason about - Fail query with IllegalStateException Result: Query will be correctly failed in the case of id space exhausting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
When we try to execute a query we will try to select / generate an id that is used. When we are not able to find one we throw an IllegalStateException. In this case we also need to ensure we fail the original promise as otherwise the user might never be notified of the problem.
Modifications:
Result:
Query will be correctly failed in the case of id space exhausting