Save HTTP 2 pseudo-header lower-case validation#13765
Merged
normanmaurer merged 1 commit intonetty:4.1from Jan 12, 2024
Merged
Conversation
Motivation: pseudo-header constants doesn't requires any further validation Modifications: anticipate pseudoheader lookup on http 2 header name validation, saving any further validation, if positive Result: Faster validations over known pseudo-headers
Contributor
Author
|
@idelpivnitskiy this can be prone to any CVE? |
Member
|
@franz1981 thanks a lot... I just checked and it seems like we already do this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
pseudo-header constants doesn't requires any further validation
Modifications:
anticipate pseudoheader lookup on http 2 header name validation, saving any further validation, if positive
Result:
Faster validations over known pseudo-headers