ConnectTimeoutException: include timeout value#13719
Merged
normanmaurer merged 1 commit intonetty:4.1from Dec 7, 2023
Merged
Conversation
Motivation: When transport throws `ConnectTimeoutException`, it's useful to know what was the pre-configured value that triggered the timeout. Modifications: - Enhance exception message for all `ConnectTimeoutException` use-cases to include `connectTimeoutMillis` value; Result: Users can understand what was a pre-configured value of `connectTimeoutMillis` that triggered `ConnectTimeoutException`.
| boolean success = false; | ||
| try { | ||
| SocketUtils.connect(socket, remoteAddress, config().getConnectTimeoutMillis()); | ||
| SocketUtils.connect(socket, remoteAddress, connectTimeoutMillis); |
Check failure
Code scanning / CodeQL
Server-side request forgery
chrisvest
approved these changes
Dec 6, 2023
normanmaurer
approved these changes
Dec 7, 2023
normanmaurer
pushed a commit
that referenced
this pull request
Dec 7, 2023
Motivation: When transport throws `ConnectTimeoutException`, it's useful to know what was the pre-configured value that triggered the timeout. Modifications: - Enhance exception message for all `ConnectTimeoutException` use-cases to include `connectTimeoutMillis` value; Result: Users can understand what was a pre-configured value of `connectTimeoutMillis` that triggered `ConnectTimeoutException`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
When transport throws
ConnectTimeoutException, it's useful to know what was the pre-configured value that triggered the timeout.Modifications:
ConnectTimeoutExceptionuse-cases to includeconnectTimeoutMillisvalue;Result:
Users can understand what was a pre-configured value of
connectTimeoutMillisthat triggeredConnectTimeoutException.