Revert "Make initializer as static (#13506)"#13553
Merged
normanmaurer merged 1 commit into4.1from Aug 17, 2023
Merged
Conversation
Motivations: By changing the code to use a static block we did remove the ability to load the class at all. This is sort of a regression as it may break existing code. Modifications: This reverts commit 1c7f0fa. Result: It's possible again to at least load the class all the time as before. Fixes #13523
13d3f34 to
86629fa
Compare
chrisvest
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations:
By changing the code to use a static block we did remove the ability to load the class at all. This is sort of a regression as it may break existing code.
Modifications:
This reverts commit 1c7f0fa.
Result:
It's possible again to at least load the class all the time as before.