Handle EHOSTUNREACH errors in io.netty.channel.unix.Errors (#13317)#13318
Merged
normanmaurer merged 1 commit intonetty:4.1from Apr 3, 2023
Merged
Handle EHOSTUNREACH errors in io.netty.channel.unix.Errors (#13317)#13318normanmaurer merged 1 commit intonetty:4.1from
normanmaurer merged 1 commit intonetty:4.1from
Conversation
Motivation:
We should throw a NoRouteToHostException when a socket connection fails with EHOSTUNREACH in the same way as
ENETUNREACH.
Modifications:
Add handling for EHOSTUNREACH
Result:
Correct exception is thrown.
Contributor
|
Good catch @tristantarrant did you already signed our license agreement? |
normanmaurer
approved these changes
Apr 2, 2023
Contributor
Author
|
Yep, I have signed the CLA |
normanmaurer
pushed a commit
that referenced
this pull request
Apr 3, 2023
…13318) Motivation: We should throw a NoRouteToHostException when a socket connection fails with EHOSTUNREACH in the same way as ENETUNREACH. Modifications: Add handling for EHOSTUNREACH Result: Correct exception is thrown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13317