Update AbstractResolveDependencies.java to handle "null" optional fields#334
Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom Oct 3, 2025
Merged
Update AbstractResolveDependencies.java to handle "null" optional fields#334slawekjaranowski merged 1 commit intomojohaus:masterfrom
slawekjaranowski merged 1 commit intomojohaus:masterfrom
Conversation
Seems null optional fields can exist which causes the rule to crash at runtime since it will try to unbox a null value. This change helps work around this.
b4fbe1f to
d21506f
Compare
Member
|
rebase and trigger build |
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Nov 4, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `extra-enforcer-rules` to 1.11.0. ### Why are the changes needed? To use the latest feature and bug fixes - https://github.com/mojohaus/extra-enforcer-rules/releases/tag/1.11.0 - mojohaus/extra-enforcer-rules#334 - mojohaus/extra-enforcer-rules#335 ### Does this PR introduce _any_ user-facing change? No, this is a build plugin. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52859 from dongjoon-hyun/SPARK-54161. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `extra-enforcer-rules` to 1.11.0. ### Why are the changes needed? To use the latest feature and bug fixes - https://github.com/mojohaus/extra-enforcer-rules/releases/tag/1.11.0 - mojohaus/extra-enforcer-rules#334 - mojohaus/extra-enforcer-rules#335 ### Does this PR introduce _any_ user-facing change? No, this is a build plugin. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52859 from dongjoon-hyun/SPARK-54161. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems null optional fields can exist which causes the rule to crash at runtime since it will try to unbox a null value.
This change helps work around this.
In the case of
MavenArtifact#setOptional, it accepts a primitivebooleanvalue only. The AetherDependency#getOptionalmethod returns ajava.lang.Booleanwhich appears to be able to have a null value.This results in the following crash on Maven 3.9.11, Enforcer rules 1.10.0: