Revert change from #480 - plugin dependencies must be resolved from plugin repositories#496
Merged
slawekjaranowski merged 1 commit intomasterfrom Oct 5, 2025
Merged
Revert change from #480 - plugin dependencies must be resolved from plugin repositories#496slawekjaranowski merged 1 commit intomasterfrom
slawekjaranowski merged 1 commit intomasterfrom
Conversation
…lugin repositories
b4ddec6 to
8447ef7
Compare
Contributor
|
Thanks! I have created #497 for adding an IT which relies on this, to verify that this does not break by accident in the future. Hopefully that is helpful. |
This was referenced Oct 4, 2025
| collectRequest.setRoot(new Dependency(RepositoryUtils.toArtifact(executableArtifact), classpathScope)); | ||
| collectRequest.setRepositories(project.getRemoteProjectRepositories()); | ||
| // as this method is called only determineRelevantPluginDependencies, se we need a plugin repository here | ||
| collectRequest.setRepositories(project.getRemotePluginRepositories()); |
There was a problem hiding this comment.
small typo: "se" should be "so"...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert a change from:
add comments in code