Skip to content

Fix for #479 - Wrong repositories used to collect deps#480

Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom
cstamas:issue-479
Aug 26, 2025
Merged

Fix for #479 - Wrong repositories used to collect deps#480
slawekjaranowski merged 1 commit intomojohaus:masterfrom
cstamas:issue-479

Conversation

@cstamas
Copy link
Copy Markdown
Member

@cstamas cstamas commented Jul 2, 2025

Wrong reposes used to collect deps.

Fixes #479

Wrong reposes used to collect deps.
@cstamas cstamas marked this pull request as draft July 3, 2025 07:38
@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Jul 10, 2025

We need to doublecheck the intent here, it was just clear that there is some mishap.

Javadoc says "Resolve the executable dependencies for the specified project" while javadoc param again speaks about plugin.

@cstamas cstamas marked this pull request as ready for review July 10, 2025 07:56
@slawekjaranowski slawekjaranowski changed the title Fix for #479 Fix for #479 - Wrong repositories used to collect deps Aug 26, 2025
@slawekjaranowski slawekjaranowski added this to the 3.6.0 milestone Aug 26, 2025
@slawekjaranowski slawekjaranowski merged commit bc59335 into mojohaus:master Aug 26, 2025
17 checks passed
@Marcono1234
Copy link
Copy Markdown
Contributor

Marcono1234 commented Oct 3, 2025

Does getRemoteProjectRepositories() consider repositories declared in <repositories> in the POM?

Gson is using exec-maven-plugin to execute a JAR which is not available in Central. Previously it used <pluginRepositories> and that worked, but this broke now with exec-maven-plugin 3.6.0. However, changing the POM to use <repositories> instead does not seem to work either: google/gson#2917

Do you have an idea what could be causing this? Am I doing something wrong here?

@slawekjaranowski
Copy link
Copy Markdown
Member

I will check again.
@Marcono1234 please create new issue as this one is closed.

@slawekjaranowski
Copy link
Copy Markdown
Member

slawekjaranowski added a commit that referenced this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong repositories used to collect deps

3 participants