Fixes #3286 : Mockito.only() points to the wanted call as unwanted if it is the first being calledIssue3286#3287
Merged
TimvdLippe merged 3 commits intomockito:mainfrom Mar 5, 2024
Conversation
…nted if it is the first being called
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3287 +/- ##
=============================================
- Coverage 85.33% 12.52% -72.81%
+ Complexity 2923 429 -2494
=============================================
Files 336 336
Lines 8906 8907 +1
Branches 1108 1109 +1
=============================================
- Hits 7600 1116 -6484
- Misses 1013 7577 +6564
+ Partials 293 214 -79 ☔ View full report in Codecov by Sentry. |
TimvdLippe
approved these changes
Mar 5, 2024
Contributor
TimvdLippe
left a comment
There was a problem hiding this comment.
Thank you for the great description and fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and example is here: #3286
Is was planning to add third commit ( PiotrPrzybylak@5fe1060 ) that replaces code in Only with calls to other verifiers, but I will do it in other PR since it breaks some tests for now:
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant