Fixes #3077 : Report unused stubbing exceptions when test filter is no-op#3078
Merged
TimvdLippe merged 1 commit intomockito:mainfrom Aug 8, 2023
Merged
Fixes #3077 : Report unused stubbing exceptions when test filter is no-op#3078TimvdLippe merged 1 commit intomockito:mainfrom
TimvdLippe merged 1 commit intomockito:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3078 +/- ##
============================================
+ Coverage 84.97% 85.46% +0.48%
- Complexity 2874 2889 +15
============================================
Files 329 329
Lines 8801 8813 +12
Branches 1093 1094 +1
============================================
+ Hits 7479 7532 +53
+ Misses 1045 994 -51
- Partials 277 287 +10
☔ View full report in Codecov by Sentry. |
TimvdLippe
reviewed
Aug 6, 2023
Contributor
Author
|
Thanks @TimvdLippe! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3077
Summary
Adds granularity to the logic that skips reporting of unused stubbings when tests are filtered. Instead of simply detecting the use of any kind of filter, intercepts uses of that filter and only skips reporting of unused stubbings when the filter actually prevents one or more tests from being run.
This allows filters (such as JUnit category excludes, which themselves can be used to separate unit and integration tests) to be applied during a test run without sacrificing the benefits of strict stubbing.
Testing coverage is added for this newly-handled case (i.e., when a filter does not prevent any tests from being run), as well as existing cases (i.e., when a filter does prevent at least one test from being run).
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant