chore: switch two-column list styles to be opt-in#5110
chore: switch two-column list styles to be opt-in#5110JoshuaKGoldberg merged 8 commits intomochajs:masterfrom
Conversation
- Adds the two-column class with the expected style for two-column unordered lists, making sure to keep the two-column style at Features and Table of Contents - Removes column style from ul element scope
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Functionally looks good, nicely done! 🎨
Requesting changes on a bit of refactoring to make the styles more clear.
92c6187 to
c358aae
Compare
Use the class two-column instead of applying the style by using its id.
Move margin-top and padding inside two-column as they are overwritten within single-column.
|
@JoshuaKGoldberg The 'Deploy Preview' check has failed even before I committed the requested changes (when I merged master to my branch), but I'm not authorized to open Netlify to check the error. Is there another way for me to verify that? Thanks! |
|
...huh, that's a new one. Does that happen for you? I'm traveling right now and blocked from trying it locally on #5113. |
|
I can see this error locally now! It seems to be happening due to Eleventy not being able to parse the properties of an object on the Jsdocs api at
* @return {FullErrorStack}
...
/**
* An object containing the full error stack results
* @private
* @typedef {Object} FullErrorStack
* @property {string} message
* @property {string} msg
* @property {string} stack
*/So please let me know your preferences and whether we should be opening those changes in another PR or if we could just apply them on this one. |
|
Nice investigation! 👏 Does that happen for you on the If it's unique to this branch (?!) then it'd be something to fix here. |
|
Requested changes were applied and all checks are passing after fix on #5116. |
|
Thanks @marjys! |
* style: closes mochajs#3702 - Adds the two-column class with the expected style for two-column unordered lists, making sure to keep the two-column style at Features and Table of Contents - Removes column style from ul element scope * refactor: add two-column class to the toc Use the class two-column instead of applying the style by using its id. * refactor: move styles that are overwritten within other classes Move margin-top and padding inside two-column as they are overwritten within single-column.


PR Checklist
status: accepting prsOverview
This PR: