Skip to content

docs: replace "New in" with "Since" in version annotations#5262

Merged
JoshuaKGoldberg merged 3 commits into
mochajs:mainfrom
TG199:NewinToSince
Dec 9, 2024
Merged

docs: replace "New in" with "Since" in version annotations#5262
JoshuaKGoldberg merged 3 commits into
mochajs:mainfrom
TG199:NewinToSince

Conversation

@TG199
Copy link
Copy Markdown
Contributor

@TG199 TG199 commented Nov 24, 2024

PR Checklist

Overview

Changes version annotations from "New in vX.Y.Z" to "Since vX.Y.Z".

* Change version annotations from "New in vX.Y.Z" to "Since vX.Y.Z"
* Align with Node.js documentation style convention
* Improve clarity for users upgrading from older versions

Closes mochajs#5166
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Nov 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks great to me, thanks for the first PR @TG199! A few small typos but you've got it correct otherwise.

Black cat using a nail file. Caption: "excellent"

Comment thread docs/index.md Outdated
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP or other posters - more information needed label Nov 24, 2024
@JoshuaKGoldberg
Copy link
Copy Markdown
Member

  • [ x ]

By the way, it's [x], not [ x ] (note the spaces). A nice little github.com feature: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists

@TG199
Copy link
Copy Markdown
Contributor Author

TG199 commented Nov 24, 2024

  • [ x ]

By the way, it's [x], not [ x ] (note the spaces). A nice little github.com feature: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists

Noted!

Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot sorry, I pressed the wrong button 🤦

Requesting changes on the typos please.

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Comment thread docs/index.md Outdated
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6f10d12 into mochajs:main Dec 9, 2024
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
)

* docs: replace "New in" with "Since" in version annotations

* Change version annotations from "New in vX.Y.Z" to "Since vX.Y.Z"
* Align with Node.js documentation style convention
* Improve clarity for users upgrading from older versions

Closes mochajs#5166

* Update docs/index.md

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

* fix typo

---------

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting for author waiting on response from OP or other posters - more information needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📝 Docs: Rephrase "New in ..." notices on versions to say "Since ..."

2 participants