You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A bit premature, no? End of April is more than a month and a half away.
There's a lot of test code that we can remove: test code that adds the --experimental-es-modules (or some such), and which we don't need anymore in Node 14. Cleans up things a bit.
A bit premature, no? End of April is more than a month and a half away.
No, I don't think so, our milestone v10.0.0 has due-date of May-01-2022. There is a lot to do until then as e.g. dropping IE11, we will need those six weeks. The creation date of this PR is not identical with the release date of v10.0.0.
There's a lot of test code that we can remove [...] I can do that once this lands.
Yes, please. And also add .js to the extensionless bin/mocha executable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area: node.jscommand-line-or-Node.js-specificsemver-majorimplementation requires increase of "major" version number; "breaking changes"
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
We drop support of Node v12 which will be end-of-life: 2022-04-30