fix: errorMapping in ResponseCodes with "4XX" and "5XX" Pattern#1735
Merged
Conversation
fix: Failed Responses now work with errorMapping with Key "4XX" and "5XX". It looks like, there should be code here to satisfy the "4XX" and "5XX" keys to match 400-499 and 500-599 StatusCodes. But it does not work yet, so i implemented it quickly. Im new here in such big Projects, so i dont know if im at the right address for this issue. I'm open for feedback tho.
baywet
previously approved these changes
Sep 9, 2024
baywet
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Failed Responses now work with errorMapping with Key "4XX" and "5XX".
Issues
"4XX"and"5XX"HashMap Key. Since this is not fully supported by core, (but almost implemented) i tried my best at it to implement this 'feature'.Changes proposed in this pull request
"4XX"and"5XX"as fallback Patterns for Statuscodes in the 400s and 500s, if the Specific Code is not a Key in the Error Map.PS: Im new here in such Big Projects, so i dont know if im at the right address for this issue. I'm open for feedback tho.