Skip to content

fix: configure release-please with PAT and correct component mapping#349

Merged
shueybubbles merged 1 commit into
microsoft:mainfrom
dlevy-msft-sql:fix/release-please
Apr 10, 2026
Merged

fix: configure release-please with PAT and correct component mapping#349
shueybubbles merged 1 commit into
microsoft:mainfrom
dlevy-msft-sql:fix/release-please

Conversation

@dlevy-msft-sql
Copy link
Copy Markdown

@dlevy-msft-sql dlevy-msft-sql commented Apr 9, 2026

  • Pin release-please-action to v4.4.0 SHA
  • Use fine-grained PAT (RELEASE_PLEASE_TOKEN)
  • Add component: '' to match existing vX.Y.Z tags (no prefix)
  • Add include-component-in-tag: false for consistent tag format
  • Update manifest version from 1.9.6 to 1.9.8 to match latest release
  • Add x-release-please-version marker to version.go
  • Opt in to Node.js 24 ahead of June 2026 deprecation deadline
  • Apply least-privilege permissions (deny-by-default at workflow level)
  • Add setup doc for PAT creation and rotation

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Release Please setup to use a fine-grained PAT for PR creation, align Release Please tagging/component behavior with existing vX.Y.Z tags, and make the driver version constant machine-updatable by Release Please.

Changes:

  • Update Release Please config/manifest to use a blank component and exclude the component from tags; bump manifest version to 1.9.8.
  • Pin googleapis/release-please-action to a specific commit SHA and switch authentication to secrets.RELEASE_PLEASE_TOKEN; set workflow default permissions to none with per-job overrides.
  • Add x-release-please-version marker to version.go and add PAT setup/rotation documentation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
version.go Adds x-release-please-version marker so Release Please can update the driver version constant.
release-please-config.json Adjusts component/tag configuration and ensures version.go is updated as an extra file.
.release-please-manifest.json Updates the manifest version from 1.9.6 to 1.9.8.
.github/workflows/release-please.yml Pins the action by SHA, uses a PAT secret, and tightens workflow permissions defaults.
.github/RELEASE_PLEASE_SETUP.md Documents creation, scoping, and rotation of the fine-grained PAT secret.

Comment thread version.go
Comment thread .github/workflows/release-please.yml Outdated
Comment thread .github/workflows/release-please.yml
- Fix component mismatch: add empty component to match existing v* tags
- Update manifest version to 1.9.8 to match latest release tag
- Use fine-grained PAT (RELEASE_PLEASE_TOKEN) for PR creation
- SHA-pin release-please-action to v4.4.0
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 for Node.js 20 deprecation
- Set least-privilege permissions at workflow level
- Handle version strings with or without v prefix in getDriverVersion
Comment thread version.go
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (17636aa) to head (dc161b1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #349       +/-   ##
===========================================
+ Coverage   79.86%   96.61%   +16.74%     
===========================================
  Files          34       89       +55     
  Lines        6646    74062    +67416     
===========================================
+ Hits         5308    71553    +66245     
- Misses       1065     2172     +1107     
- Partials      273      337       +64     
Flag Coverage Δ
unittests 96.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
version.go 100.00% <100.00%> (ø)

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shueybubbles shueybubbles merged commit 23bac05 into microsoft:main Apr 10, 2026
7 checks passed
AbbasLB pushed a commit to AbbasLB/go-mssqldb that referenced this pull request Apr 10, 2026
…icrosoft#349)

- Fix component mismatch: add empty component to match existing v* tags
- Update manifest version to 1.9.8 to match latest release tag
- Use fine-grained PAT (RELEASE_PLEASE_TOKEN) for PR creation
- SHA-pin release-please-action to v4.4.0
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 for Node.js 20 deprecation
- Set least-privilege permissions at workflow level
- Handle version strings with or without v prefix in getDriverVersion
@dlevy-msft-sql dlevy-msft-sql deleted the fix/release-please branch April 10, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants