Conversation
Protocol-relative URLs (e.g. `//evil.com/path`) bypassed the existing relative-URL guard in `build_exclusive_url`, allowing an attacker-controlled URL to override the connection's base host. The `//` prefix matched the `/` check in `start_with?`, so these URLs were passed through to `URI#+` which treated them as authority references, replacing the host. Extend the guard condition so that URLs starting with `//` are prefixed with `./`, neutralizing the authority component and keeping requests scoped to the configured base host. This backport maintains backward compatibility with the 1.x branch's colon-escaping behavior for opaque URIs like `service:search`. Security: CVE-2026-25765, GHSA-33mh-2634-fwr2 Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport
CVE-2026-25765to the 1.x releases. To be released as v1.10.5.Security Advisory: GHSA-33mh-2634-fwr2
Fixes #1664