fix: string literals are injectable on MySQL when backslash escapes (\\') are used.#1754
Merged
igalklebanov merged 2 commits intomasterfrom Mar 20, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ ⏱️ No benchmark changes detected following cae1f5a. |
commit: |
igalklebanov
added a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
MySQL treats backslashes as escapes in string literals via a system setting by default.
PostgreSQL treats backslashes in string literals as regular characters via system setting by default. Other databases do the same and don't provide a system setting.
This PR denies a SQL injection vector for MySQL users who use
sql.lit(string)or similar orKysely<any>/ignoring compilation errors when usingeb.ref(column, '->$').key(injection).A clever attacker could detect doubling of
'to prevent standard literal string SQL injections, and could escape his'with a backslash turning the doubling of'into introduction of a single'and enabling malicious text to be "queryable" after it.