fix: missing sideEffects: false in root package.json resulting in bigger bundles in various bundlers.#1746
Merged
igalklebanov merged 1 commit intomasterfrom Mar 18, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ ⏱️ No benchmark changes detected following 1528e1c. |
commit: |
sideEffects: false in root package.json.
sideEffects: false in root package.json.sideEffects: false in root package.json resulting in bigger bundles in various bundlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
closes #1743.
This PR adds
sideEffects: falseto the mainpackage.jsonfile as suggested in the issue.Seems to be legit.