fix: sql dialect returning order issue#1691
Merged
igalklebanov merged 3 commits intokysely-org:masterfrom Jan 25, 2026
Merged
Conversation
|
@hwisu is attempting to deploy a commit to the Kysely Team Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
igalklebanov
approved these changes
Jan 25, 2026
Member
igalklebanov
left a comment
There was a problem hiding this comment.
Hey 👋
Thanks! 🙏
Your fix worked. 👏
Made some changes since it was duplicating the entire update query visitor into the SQLite query compiler. This is wasteful given that only SQLite's spec (under certain system flag/s), supports limit/order by AND returning clauses in an update query. A much cheaper solution was to just reorder the clause handling in the default query compiler.
Contributor
Author
|
Thanks for the feedback! Appreciate the cleanup and the simpler approach here. 🌮 |
This was referenced Jan 31, 2026
This was referenced Feb 8, 2026
This was referenced Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1631
Howdy,
I made a small fix and added one test case.
I tried to get assigned, but since it looked like a small fix, I went ahead and opened a PR first.
Thanks for your understanding!
naive reproduction : https://github.com/hwisu/kysely-1631
discord request (from me) : https://discord.com/channels/890118421587578920/1073949928453328897/1462700413253062666