Add ExtractColumnType and DrainOuterGeneric type exports#1679
Merged
igalklebanov merged 7 commits intokysely-org:masterfrom Jan 17, 2026
Merged
Add ExtractColumnType and DrainOuterGeneric type exports#1679igalklebanov merged 7 commits intokysely-org:masterfrom
ExtractColumnType and DrainOuterGeneric type exports#1679igalklebanov merged 7 commits intokysely-org:masterfrom
Conversation
Fixes error seen in kysely-org#1115 (comment) ``` The inferred type of 'all' cannot be named without a reference to 'node_modules/kysely/dist/esm/util/type-utils.js'. This is likely not portable. A type annotation is necessary. ``` (when using `composite: true` in typescript)
|
@mifi is attempting to deploy a commit to the Kysely Team Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Hey 👋 Thanks! 🙏 Can you add an example in |
Contributor
Author
|
hi! thanks, i've added a file. i believe it will fail with such a simple case |
commit: |
igalklebanov
approved these changes
Jan 17, 2026
Member
igalklebanov
left a comment
There was a problem hiding this comment.
The original example was good enough, just needed a .execute().
Detected that also DrainOuterGeneric needs to be exported.
🚀
ExtractColumnType type exportExtractColumnType and DraonOuterGeneric type exports
ExtractColumnType and DraonOuterGeneric type exportsExtractColumnType and DrainOuterGeneric type exports
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error seen in #1115 (comment)
(when using
composite: truein typescript)