Skip to content

fix(TransactionBuilder): auto rollback only if transaction begun.#1580

Merged
igalklebanov merged 5 commits intomasterfrom
rollback-only-after-begin
Sep 14, 2025
Merged

fix(TransactionBuilder): auto rollback only if transaction begun.#1580
igalklebanov merged 5 commits intomasterfrom
rollback-only-after-begin

Conversation

@igalklebanov
Copy link
Copy Markdown
Member

Hey 👋

closes #952.

This PR ensures rollbackTransaction is only called if beginTransaction was successful with a simple flag.

@igalklebanov igalklebanov added the bug Something isn't working label Sep 14, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
kysely Ready Ready Preview Comment Sep 14, 2025 11:33am

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 14, 2025

✅ ⏱️ No benchmark changes detected following 264a4a7.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Sep 14, 2025

kysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@1580

commit: 264a4a7

@igalklebanov igalklebanov changed the title fix: auto rollback only if begun. fix: auto rollback only if transaction begun. Sep 14, 2025
@igalklebanov igalklebanov merged commit b0ab41d into master Sep 14, 2025
29 checks passed
@igalklebanov igalklebanov changed the title fix: auto rollback only if transaction begun. fix(TransactionBuilder): auto rollback only if transaction begun. Sep 14, 2025
@igalklebanov igalklebanov deleted the rollback-only-after-begin branch September 14, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attempting to rollback a connection that fails to get created

1 participant