chore(docs): optimize demo video.#1567
Merged
igalklebanov merged 10 commits intomasterfrom Aug 25, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ ⏱️ No benchmark changes detected following 18ec58c. |
commit: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the demo video component and related configurations to improve page load performance and user experience. The changes focus on implementing video loading best practices and fixing React JSX attribute issues.
- Added programmatic video loading with poster image to improve Largest Contentful Paint (LCP)
- Fixed JSX attribute naming conventions from HTML to React format
- Updated GitHub workflow path filters and tolerance settings
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/components/DemoVideo.tsx | Implements programmatic video loading with useEffect, adds poster image and WebM source |
| site/src/components/SectionQuotes/Quote.tsx | Converts HTML attributes to React JSX format (fillRule, clipRule, stopColor) |
| site/src/pages/index.tsx | Initializes StackBlitz URL state immediately instead of empty string |
| .github/workflows/preview.yml | Changes from paths-ignore to paths filter for workflow triggers |
| .github/workflows/compare.yml | Updates tolerance setting from mixed-better to mixed |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR adds a poster image while the video is loading to improve the experience.
It adds a
webmsource to the video - ~50% smaller, faster to load.It aims to improve Largest Contentful Paint (LCP) by setting preload to "none" to prevent blocking initial page load, removing
autoPlayand instead loading and playing the video programmatically in auseEffecton mount - which also avoids browser auto play restrictions hopefully.