fix(WithSchemaTransformer): using table of merge into queries unhandled.#1554
Merged
igalklebanov merged 3 commits intokysely-org:masterfrom Aug 24, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
318c51f to
589f5ae
Compare
589f5ae to
7b75a5f
Compare
igalklebanov
approved these changes
Aug 24, 2025
Member
igalklebanov
left a comment
There was a problem hiding this comment.
Hey 👋
Thanks! 🙏
The test case was not reproducing the bug - made sure it does.
using table of merge into queries unhandled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
withSchemamethod is documented to set the default schema for all table references that don't explicitly specify a schema (docs). However, it currently fails to apply the schema to join tables inmergeIntostatements.When using
withSchemawithmergeInto, the schema is not applied to the table specified in the.using()clause:In this example, the
persontable correctly receives the schema prefix, but thepettable in the.using()clause does not.This PR updates the
WithSchemaTransformerclass to properly handle join tables inmergeIntostatements.