fix(mssql): socket error handling during connect.#1463
Merged
igalklebanov merged 2 commits intokysely-org:masterfrom May 24, 2025
Merged
fix(mssql): socket error handling during connect.#1463igalklebanov merged 2 commits intokysely-org:masterfrom
igalklebanov merged 2 commits intokysely-org:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances MSSQL connection handling by properly tracking socket errors, improving promise cleanup, and migrating validation to a private method to avoid infinite reconnect loops.
- Switches test hook from async to sync where appropriate.
- Updates
Deferredto clear handlers after resolution/rejection. - Refactors
MssqlConnectionto use a deferred connect flow, trackESOCKETerrors, and introduce a privatevalidatemethod.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/node/src/disconnects.test.ts | Changed Mocha before hook from async to sync to match the new connection initialization behavior |
| src/util/deferred.ts | Cleans up resolve/reject handlers after they’re invoked to prevent memory leaks |
| src/dialect/mssql/mssql-driver.ts | Adds socket‐error tracking, replaces public validate with a private symbol method, and refines connect/reset/destroy logic |
Comments suppressed due to low confidence (1)
src/dialect/mssql/mssql-driver.ts:178
- Consider adding a test that simulates an 'ESOCKET' error during connection to verify that
#hasSocketErroris set and subsequent validations correctly fail.
this.#hasSocketError = true
koskimas
approved these changes
May 21, 2025
koskimas
reviewed
May 21, 2025
|
Thank you for that one ☝️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
closes #1461
Connection establishment errors were not handled correctly leading to infinite loops and undesirable behavior in the MSSQL Dialect. Also, connection disruptions were probably mishandled as well.