fix: bigint immediates are appended as string literals instead of numbers.#1445
Merged
igalklebanov merged 1 commit intokysely-org:masterfrom May 24, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
51deb65 to
f4bf237
Compare
f4bf237 to
dc96c63
Compare
test.
dc96c63 to
54631e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
closes #1437
bigintimmediate values are being appended as string literals instead of numbers.e.g.
123123nis appended to the query as'123123'instead of123123.Noticed when using
sql.litwithbigintvalues inoffset. This works in PostgreSQL, but fails in MySQL and MSSQL. There's a workaround (usingsql.raw), but that's not intuitive.Question is, am I missing anything?