ensure jsdocs check's dts is source of truth for docs examples.#1436
Merged
igalklebanov merged 3 commits intokysely-org:masterfrom Apr 27, 2025
Merged
ensure jsdocs check's dts is source of truth for docs examples.#1436igalklebanov merged 3 commits intokysely-org:masterfrom
igalklebanov merged 3 commits intokysely-org:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
So we are testing our jsdocs code examples, and made changes to the examples. That's awesome.
To get that up and running, we created a
d.tsfile that contains all the types needed for our jsdocs examples.I forgot to also make sure the docs site's examples' types are aligned with this new
d.tsfile.This PR makes it so that the check's
d.tsfile is auto generated as the docs site's playground types.Without these changes, the docs site's examples are broken and show lots of type errors.