Skip to content

add support for constraint renaming. Closes #647#1408

Merged
koskimas merged 1 commit intov0.28from
add-constraint-renaming
Apr 2, 2025
Merged

add support for constraint renaming. Closes #647#1408
koskimas merged 1 commit intov0.28from
add-constraint-renaming

Conversation

@koskimas
Copy link
Copy Markdown
Member

The title says it all. It seems only postgres supports this though.

@koskimas koskimas requested a review from igalklebanov March 30, 2025 14:03
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 8:33am

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 30, 2025

kysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@1408

commit: 61f49d6

@koskimas koskimas force-pushed the add-constraint-renaming branch from 0dc90ed to 85724ab Compare March 30, 2025 14:04
@koskimas koskimas changed the title Add constraint renaming add support for constraint renaming Mar 30, 2025
@koskimas koskimas changed the base branch from master to v0.28 March 30, 2025 14:04
@koskimas koskimas changed the title add support for constraint renaming add support for constraint renaming. Closes #647 Mar 30, 2025
Comment thread src/operation-node/rename-constraint-node.ts
Comment thread src/query-compiler/default-query-compiler.ts Outdated
Comment thread src/schema/alter-table-builder.ts
Copy link
Copy Markdown
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@koskimas koskimas force-pushed the add-constraint-renaming branch from 85724ab to a7a9a4d Compare March 30, 2025 16:22
@igalklebanov igalklebanov added enhancement New feature or request postgres Related to PostgreSQL api Related to library's API labels Mar 30, 2025
@koskimas
Copy link
Copy Markdown
Member Author

koskimas commented Mar 30, 2025

Something went wrong in the rebase with the test file. I'll sort that out tomorrow or later.

@koskimas
Copy link
Copy Markdown
Member Author

koskimas commented Apr 2, 2025

Something went wrong in the rebase with the test file. I'll sort that out tomorrow or later.

Actually the diff is just weird. Nothing's wrong.

@koskimas koskimas merged commit 13f2257 into v0.28 Apr 2, 2025
27 checks passed
igalklebanov pushed a commit that referenced this pull request Apr 6, 2025
@igalklebanov igalklebanov mentioned this pull request Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to library's API enhancement New feature or request postgres Related to PostgreSQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants