Fix: XML whitespace trims while pretty print#2415
Merged
ptrthomas merged 2 commits intokaratelabs:developfrom Oct 11, 2023
Merged
Fix: XML whitespace trims while pretty print#2415ptrthomas merged 2 commits intokaratelabs:developfrom
ptrthomas merged 2 commits intokaratelabs:developfrom
Conversation
added 2 commits
October 10, 2023 20:34
|
Thanks for the work on this. I can see that the act of logging will not change the xml. I do think though that the pretty printing should preserve the whitespace within an xml element value, as it is significant. What you see in the log would not be the correct element value when the whitespace has been stripped. In XmlUtilsTest line 238 the expected value should be:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The above PR resolves the bug which causes the XML element with whitespace in the left or right to be trimmed after passing the variable through karate.log or print.
The idea of the fix is to clone a temporary node while serializing the XML node to string in case of pretty print, as the code trims the whitespace of the element while pretty printing and does that directly on the object itself causing it to change.
Issue: #2385
Screenshots of failing test cases before the changes:
Thanks for contributing to this Pull Request. Make sure that you submit this Pull Request against the
developbranch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.