Update handlers.py to fix ioloop blockers(sync file operations)#1617
Merged
Conversation
3622815 to
6f0ac2e
Compare
Carreau
approved these changes
Apr 30, 2026
Contributor
Carreau
left a comment
There was a problem hiding this comment.
Rebased on main to exert the test on python 3.13 and 3.14.
Would and async version of kernelspec_model be possible/desirable (yet it's a change of API, but you looked at the subject in more depth than I)
+1 to merge once test are passing.
Contributor
|
failure is unrelated. #1624 should fix it. |
Currently kernel spec api implementation uses sync io API that blocks the server's ioloop resulting in suboptimal responsiveness.
…missing. Update handlers.py implementation to log when spec and resources are missing, to maintain original behavior.
Fix incorrect check for resource field
6f0ac2e to
73b3c27
Compare
Contributor
|
rebasing once more to see if the issue goes away, otherwise merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently synchronous IO API calls are being made in a asyncio context resulting in ioloop blockage that affects server responsiveness.
this PR addresses the issue using asyncio.to_thread.