Validate extension name before toggling through CLI#1509
Merged
afshin merged 2 commits intoMay 1, 2025
Conversation
Contributor
Author
|
@Zsailer Could I get a review on this ? Also I think I should add a test for this. |
Collaborator
|
It looks like the downstream test failures are unrelated and will pass once #1510 is merged. |
Member
|
Thanks, @Darshan808. This looks good. I went ahead and added a unit test for this as well. |
Zsailer
approved these changes
Apr 14, 2025
d660015 to
aa796ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1507
Description
This PR fixes an issue where running
would misleadingly add the non-existent or misspelled extension to extension list and mark it as disabled, even though it was never installed.
Fix
A validation step is added to check if the extension name is valid and currently installed. If the extension is not found, an error is logged and it is not added to the extension list.
Changes
This issue was bugging me for a while, and I believe this change enhances the CLI user experience.